netdev - Re: [PATCH v3 net-next 00/19] TLS offload rx, netdev & mlx5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180712165438.GB32492@macbook-pro-6.local.dhcp.thefacebook.com>
Date:   Thu, 12 Jul 2018 09:54:38 -0700
From:   Dave Watson <davejwatson@...com>
To:     Boris Pismenny <borisp@...lanox.com>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <aviadye@...lanox.com>, <saeedm@...lanox.com>
Subject: Re: [PATCH v3 net-next 00/19] TLS offload rx, netdev & mlx5

On 07/11/18 10:54 PM, Boris Pismenny wrote:
> Hi,
> 
> The following series provides TLS RX inline crypto offload.

All the tls patches look good to me except #10

"tls: Fix zerocopy_from_iter iov handling"

which seems to break the non-device zerocopy flow. 

The integration is very clean, thanks!

> 
> v2->v3:
>     - Fix typo
>     - Adjust cover letter
>     - Fix bug in zero copy flows
>     - Use network byte order for the record number in resync
>     - Adjust the sequence provided in resync
> 
> v1->v2:
>     - Fix bisectability problems due to variable name changes
>     - Fix potential uninitialized return value
>