netdev - Re: [PATCH v3 net-next 00/19] TLS offload rx, netdev & mlx5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8dd398b3-fdd1-b907-0792-c17ba948e877@mellanox.com>
Date:   Thu, 12 Jul 2018 15:20:18 -0400
From:   Boris Pismenny <borisp@...lanox.com>
To:     Dave Watson <davejwatson@...com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, aviadye@...lanox.com,
        saeedm@...lanox.com
Subject: Re: [PATCH v3 net-next 00/19] TLS offload rx, netdev & mlx5

Hi Dave,

On 7/12/2018 12:54 PM, Dave Watson wrote:
> On 07/11/18 10:54 PM, Boris Pismenny wrote:
>> Hi,
>>
>> The following series provides TLS RX inline crypto offload.
> 
> All the tls patches look good to me except #10
> 
> "tls: Fix zerocopy_from_iter iov handling"
> 
> which seems to break the non-device zerocopy flow.

Thanks for reviewing!

Sorry, it seems to break the zerocopy send flow, and I've tested only 
with the receive flow offload disabled.

I'll fix it in v4. I think that adding a flag to indicate whether a 
revert is needed should do the trick. In the receive flow the revert is 
needed to handle potential errors, while in the transmit flow it needs 
to be removed.

> 
> The integration is very clean, thanks!	
> 
>>
>> v2->v3:
>>      - Fix typo
>>      - Adjust cover letter
>>      - Fix bug in zero copy flows
>>      - Use network byte order for the record number in resync
>>      - Adjust the sequence provided in resync
>>
>> v1->v2:
>>      - Fix bisectability problems due to variable name changes
>>      - Fix potential uninitialized return value
>>