netdev - Re: [PATCH iproute2-next v2] net:sched: add action inheritdsfield to skbedit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180712205059.GH8880@localhost.localdomain>
Date:   Thu, 12 Jul 2018 17:50:59 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Qiaobin Fu <qiaobinf@...edu>
Cc:     dsahern@...il.com, stephen@...workplumber.org, davem@...emloft.net,
        netdev@...r.kernel.org, jhs@...atatu.com, michel@...irati.com.br,
        xiyou.wangcong@...il.com, dcaratti@...hat.com
Subject: Re: [PATCH iproute2-next v2] net:sched: add action inheritdsfield to
 skbedit

On Thu, Jul 12, 2018 at 12:09:26PM -0400, Qiaobin Fu wrote:
> @@ -156,6 +162,9 @@ parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
>  	if (flags & SKBEDIT_F_PTYPE)
>  		addattr_l(n, MAX_MSG, TCA_SKBEDIT_PTYPE,
>  			  &ptype, sizeof(ptype));
> +	if (pure_flags != 0)
> +		addattr_l(n, MAX_MSG, TCA_SKBEDIT_FLAGS,
> +			&pure_flags, sizeof(pure_flags));

It is missing 2 spaces  ^--- here, to make the indentation right. (as
in the block above)

  Marcelo