netdev - Re: [PATCH iproute2-next v2] net:sched: add action inheritdsfield to skbedit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180712150526.6c4ed31d@xeon-e3>
Date:   Thu, 12 Jul 2018 15:05:26 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Qiaobin Fu <qiaobinf@...edu>
Cc:     dsahern@...il.com, davem@...emloft.net, netdev@...r.kernel.org,
        jhs@...atatu.com, michel@...irati.com.br,
        marcelo.leitner@...il.com, xiyou.wangcong@...il.com,
        dcaratti@...hat.com
Subject: Re: [PATCH iproute2-next v2] net:sched: add action inheritdsfield
 to skbedit

On Thu, 12 Jul 2018 12:09:26 -0400
Qiaobin Fu <qiaobinf@...edu> wrote:

> +		if (*flags & SKBEDIT_F_INHERITDSFIELD)
> +			print_string(PRINT_ANY, "inheritdsfield", " %s",
> +				     "inheritdsfield");

Flags should be represented in JSON output as a null value (or boolean).
		print_null(PRINT_ANY, "inheritdsfield", " %s", "inheritdsfield");
This will generate:
			"inheritdsfield" : null,
Instead of:

			"inheritdsfield" : "inheritdsfield",