netdev - Re: [PATCH net-next] macvlan: Change status when lower device goes down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180711.230740.435912925736299517.davem@davemloft.net>
Date:   Wed, 11 Jul 2018 23:07:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     travisb@...sta.com
Cc:     netdev@...r.kernel.org, skrishnan@...sta.com
Subject: Re: [PATCH net-next] macvlan: Change status when lower device goes
 down

From: Travis Brown <travisb@...sta.com>
Date: Tue, 10 Jul 2018 00:35:01 +0000

> Today macvlan ignores the notification when a lower device goes
> administratively down, preventing the lack of connectivity from
> bubbling up.
> 
> Processing NETDEV_DOWN results in a macvlan state of LOWERLAYERDOWN
> with NO-CARRIER which should be easy to interpret in userspace.
> 
> 2: lower: <BROADCAST,MULTICAST> mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000
> 3: macvlan@...er: <NO-CARRIER,BROADCAST,MULTICAST,UP,M-DOWN> mtu 1500 qdisc noqueue state LOWERLAYERDOWN mode DEFAULT group default qlen 1000
> 
> Signed-off-by: Suresh Krishnan <skrishnan@...sta.com>
> Signed-off-by: Travis Brown <travisb@...sta.com>

Seems reasonable, applied, thanks.