netdev - Re: [PATCH net-next 0/3] mlxsw: ERSPAN: Take LACP state into consideration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180711.231032.1915465237915781710.davem@davemloft.net>
Date:   Wed, 11 Jul 2018 23:10:32 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, petrm@...lanox.com, jiri@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH net-next 0/3] mlxsw: ERSPAN: Take LACP state into
 consideration

From: Ido Schimmel <idosch@...lanox.com>
Date: Tue, 10 Jul 2018 10:02:56 +0300

> Petr says:
> 
> When offloading mirror-to-gretap, mlxsw needs to preroute the path that
> the encapsulated packet will take. That path may include a LAG device
> above a front panel port. So far, mlxsw resolved the path to the first
> up front panel slave of the LAG interface, but that only reflects
> administrative state of the port. It neglects to consider whether the
> port actually has a carrier, and what the LACP state is. This patch set
> aims to address these problems.
> 
> Patch #1 publishes team_port_get_rcu().
> 
> Then in patch #2, a new function is introduced,
> mlxsw_sp_port_dev_check(). That returns, for a given netdevice that is a
> slave of a LAG device, whether that device is "txable", i.e. whether the
> LAG master would send traffic through it. Since there's no good place to
> put LAG-wide helpers, introduce a new header include/net/lag.h.
> 
> Finally in patch #3, fix the slave selection logic to take into
> consideration whether a given slave has a carrier and whether it is
> txable.

Series applied, thank you.