netdev - Re: [PATCH net] net/ipv6: Do not allow device only routes via the multipath API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a9f43a4e-29a5-d6f7-e832-245b7994d8ef@gmail.com>
Date:   Fri, 13 Jul 2018 10:45:15 -0400
From:   David Ahern <dsahern@...il.com>
To:     Stefano Brivio <sbrivio@...hat.com>, dsahern@...nel.org
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net] net/ipv6: Do not allow device only routes via the
 multipath API

On 7/13/18 7:28 AM, Stefano Brivio wrote:
> On Thu, 12 Jul 2018 14:48:23 -0700
> dsahern@...nel.org wrote:
> 
>> @@ -4388,6 +4388,13 @@ static int ip6_route_multipath_add(struct fib6_config *cfg,
>>  			rt = NULL;
>>  			goto cleanup;
>>  		}
>> +		if (!rt6_qualify_for_ecmp(rt)) {
>> +			err = EINVAL;
> 
> Shouldn't this be -EINVAL, just for consistency? E.g. we might return a
> -ENOMEM from ip6_route_info_append(), etc.
> 

oops, yes, missing the '-'. thanks for catching that.