netdev - Re: [PATCH net] net/ipv6: Do not allow device only routes via the multipath API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180713132845.64854ff3@epycfail>
Date:   Fri, 13 Jul 2018 13:28:45 +0200
From:   Stefano Brivio <sbrivio@...hat.com>
To:     dsahern@...nel.org
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net] net/ipv6: Do not allow device only routes via the
 multipath API

On Thu, 12 Jul 2018 14:48:23 -0700
dsahern@...nel.org wrote:

> @@ -4388,6 +4388,13 @@ static int ip6_route_multipath_add(struct fib6_config *cfg,
>  			rt = NULL;
>  			goto cleanup;
>  		}
> +		if (!rt6_qualify_for_ecmp(rt)) {
> +			err = EINVAL;

Shouldn't this be -EINVAL, just for consistency? E.g. we might return a
-ENOMEM from ip6_route_info_append(), etc.

-- 
Stefano