netdev - Re: [PATCH v4 net-next 19/19] net/mlx5e: Kconfig, mutually exclude compilation of TLS and IPsec accel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180713.144440.1556859491192856560.davem@davemloft.net>
Date:   Fri, 13 Jul 2018 14:44:40 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     borisp@...lanox.com
Cc:     netdev@...r.kernel.org, davejwatson@...com, aviadye@...lanox.com,
        saeedm@...lanox.com
Subject: Re: [PATCH v4 net-next 19/19] net/mlx5e: Kconfig, mutually exclude
 compilation of TLS and IPsec accel

From: Boris Pismenny <borisp@...lanox.com>
Date: Fri, 13 Jul 2018 16:03:01 -0400

> We currently have no devices that support both TLS and IPsec using the
> accel framework

I read this the first time, and this is not what I am objecting to.

The compile time limitation is the problem, not the run time
limitation.

> Looking a bit more carefully at the code. We don't need this patch,
> because we still don't have a deviceID for both TLS and IPsec, so the
> problematic flow cannot happen. So we've just been over zealous
> here. I'll remove this patch and send a v5.

Ok, thanks.