netdev - Re: [PATCH v3 net-next 3/3] rds: Extend RDS API for IPv6 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da7e76c6-1b52-08d2-b960-ec6067df3fca@oracle.com>
Date:   Fri, 13 Jul 2018 15:00:59 -0700
From:   Santosh Shilimkar <santosh.shilimkar@...cle.com>
To:     David Miller <davem@...emloft.net>, ka-cheong.poon@...cle.com
Cc:     netdev@...r.kernel.org, sowmini.varadhan@...cle.com,
        rds-devel@....oracle.com
Subject: Re: [PATCH v3 net-next 3/3] rds: Extend RDS API for IPv6 support

Hi Dave,

On 7/13/2018 2:25 PM, David Miller wrote:
> From: Ka-Cheong Poon <ka-cheong.poon@...cle.com>
> Date: Fri, 13 Jul 2018 04:02:59 -0700
> 
>> @@ -52,7 +52,7 @@
>>   #define RDS_RECVERR			5
>>   #define RDS_CONG_MONITOR		6
>>   #define RDS_GET_MR_FOR_DEST		7
>> -#define SO_RDS_TRANSPORT		8
>> +#define SO_RDS_TRANSPORT		9
> 
> There is no way you can change this value without breaking
> applications.
> 
Downstream Oracle shipping application have been built
with 9 as a SO_RDS_TRANSPORT from beginning. 8 is used
for RDS_CONN_RESET but support for it doesn't exist
upstream yet. Ka-cheong was aligning them so that we
have same number upstream as well as in shipping products.

Ofcourse any application built using upstream header and
using SO_RDS_TRANSPORT will break but since this particular
option was added for special case(application wants to
upfront select transport instead letting bind figure it out),
our hope its not used by other application(s).

Regards,
Santosh