netdev - Re: [PATCH net-next 4/5] net: mvpp2: debugfs: add entries for classifier flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 14 Jul 2018 13:20:47 +0200
From:   Maxime Chevallier <maxime.chevallier@...tlin.com>
To:     davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        thomas.petazzoni@...tlin.com, gregory.clement@...tlin.com,
        miquel.raynal@...tlin.com, nadavh@...vell.com, stefanc@...vell.com,
        ymarkman@...vell.com, mw@...ihalf.com
Subject: Re: [PATCH net-next 4/5] net: mvpp2: debugfs: add entries for
 classifier flows

On Fri, 13 Jul 2018 18:13:43 +0200
Maxime Chevallier <maxime.chevallier@...tlin.com> wrote:


>+static int mvpp2_dbgfs_flow_id_show(struct seq_file *s, void *unused)
>+{
>+	struct mvpp2_dbgfs_flow_entry *entry = s->private;
>+	struct mvpp2_cls_flow *f;
>+
>+	f = mvpp2_cls_flow_get(entry->flow);

This won't compile with commit
9cee8c437543 ("net: mvpp2: mvpp2_cls_flow_get() can be static")

I should have seen that missing static in the RSS series, now that
it's fixed I'll send a V2 of that debugfs series, to make that function
non static for the right reason this time.

Thanks,

Maxime