netdev - Re: [PATCH net-next 4/5] net: mvpp2: debugfs: add entries for classifier flows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Jul 2018 09:01:22 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc:     kbuild-all@...org, davem@...emloft.net,
        Maxime Chevallier <maxime.chevallier@...tlin.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        thomas.petazzoni@...tlin.com, gregory.clement@...tlin.com,
        miquel.raynal@...tlin.com, nadavh@...vell.com, stefanc@...vell.com,
        ymarkman@...vell.com, mw@...ihalf.com
Subject: Re: [PATCH net-next 4/5] net: mvpp2: debugfs: add entries for
 classifier flows

Hi Maxime,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Maxime-Chevallier/net-mvpp2-add-debugfs-interface/20180716-014927
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=powerpc 
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago

All errors (new ones prefixed by >>):

>> drivers/net//ethernet/marvell/mvpp2/mvpp2_cls.c:575:31: error: static declaration of 'mvpp2_cls_flow_get' follows non-static declaration
    static struct mvpp2_cls_flow *mvpp2_cls_flow_get(int flow)
                                  ^~~~~~~~~~~~~~~~~~
   In file included from drivers/net//ethernet/marvell/mvpp2/mvpp2_cls.c:11:0:
   drivers/net//ethernet/marvell/mvpp2/mvpp2_cls.h:216:24: note: previous declaration of 'mvpp2_cls_flow_get' was here
    struct mvpp2_cls_flow *mvpp2_cls_flow_get(int flow);
                           ^~~~~~~~~~~~~~~~~~

# https://github.com/0day-ci/linux/commit/0a0aa09b1f053ab79e9e87ca21ce51f14764ce70
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 0a0aa09b1f053ab79e9e87ca21ce51f14764ce70
vim +/mvpp2_cls_flow_get +575 drivers/net//ethernet/marvell/mvpp2/mvpp2_cls.c

b1a962c6 Maxime Chevallier 2018-07-12  574  
9cee8c43 kbuild test robot 2018-07-14 @575  static struct mvpp2_cls_flow *mvpp2_cls_flow_get(int flow)
f9358e12 Maxime Chevallier 2018-07-12  576  {
f9358e12 Maxime Chevallier 2018-07-12  577  	if (flow >= MVPP2_N_FLOWS)
f9358e12 Maxime Chevallier 2018-07-12  578  		return NULL;
f9358e12 Maxime Chevallier 2018-07-12  579  
f9358e12 Maxime Chevallier 2018-07-12  580  	return &cls_flows[flow];
f9358e12 Maxime Chevallier 2018-07-12  581  }
f9358e12 Maxime Chevallier 2018-07-12  582  

:::::: The code at line 575 was first introduced by commit
:::::: 9cee8c4375431d5087466eacf6f8f436210e56ea net: mvpp2: mvpp2_cls_flow_get() can be static

:::::: TO: kbuild test robot <fengguang.wu@...el.com>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (57634 bytes)