netdev - Re: [PATCH net-next] tcp: remove redundant rcv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180714.112204.1831168896985469983.davem@davemloft.net>
Date:   Sat, 14 Jul 2018 11:22:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     laoar.shao@...il.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        shaoyafang@...ichuxing.com, edumazet@...gle.com
Subject: Re: [PATCH net-next] tcp: remove redundant rcv_nxt update

From: Yafang Shao <laoar.shao@...il.com>
Date: Sat, 14 Jul 2018 16:36:29 +0800

> tcp_rcv_nxt_update() is already executed in tcp_data_queue().
> This line is redundant.
> 
> See bellow,
> 	tcp_queue_rcv
> 		tcp_rcv_nxt_update(tcp_sk(sk), TCP_SKB_CB(skb)->end_seq);
> 	tcp_rcv_nxt_update(tp, TCP_SKB_CB(skb)->end_seq); <<<< redundant
> 
> Signed-off-by: Yafang Shao <laoar.shao@...il.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.