netdev - Re: [PATCH][net-next][v2] net: convert gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180716.134131.1554894339720285923.davem@davemloft.net>
Date:   Mon, 16 Jul 2018 13:41:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lirongqing@...du.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, sbrivio@...hat.com
Subject: Re: [PATCH][net-next][v2] net: convert gro_count to bitmask

From: Li RongQing <lirongqing@...du.com>
Date: Fri, 13 Jul 2018 14:41:36 +0800

> gro_hash size is 192 bytes, and uses 3 cache lines, if there is few
> flows, gro_hash may be not fully used, so it is unnecessary to iterate
> all gro_hash in napi_gro_flush(), to occupy unnecessary cacheline.
> 
> convert gro_count to a bitmask, and rename it as gro_bitmask, each bit
> represents a element of gro_hash, only flush a gro_hash element if the
> related bit is set, to speed up napi_gro_flush().
> 
> and update gro_bitmask only if it will be changed, to reduce cache
> update
> 
> Suggested-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Li RongQing <lirongqing@...du.com>
> Cc: Stefano Brivio <sbrivio@...hat.com>
> ---
> netperf shows no difference, maybe because my testing machine has large
> cache

Applied.