netdev - Re: [PATCH net-next] cxgb4: do not return DUPLEX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180716.134405.1632680219473939681.davem@davemloft.net>
Date:   Mon, 16 Jul 2018 13:44:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ganeshgr@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com,
        indranil@...lsio.com, venkatesh@...lsio.com, leedom@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: do not return DUPLEX_UNKNOWN when link
 is down

From: Ganesh Goudar <ganeshgr@...lsio.com>
Date: Fri, 13 Jul 2018 17:56:55 +0530

> We were returning DUPLEX_UNKNOWN in get_link_ksettings() when
> the link was down.  Unfortunately, this causes a problem when
> "ethtool -s autoneg on" is issued for a link which is down because
> the ethtool code first reads the settings and then reapplies them
> with only the changes provided on the command line. Which results
> in us diving into set_link_ksettings() with DUPLEX_UNKNOWN which is
> not DUPLEX_FULL, so set_link_ksettings() throws an -EINVAL error.
> do not return DUPLEX_UNKNOWN to fix the issue.
> 
> Signed-off-by: Casey Leedom <leedom@...lsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@...lsio.com>

Applied.