netdev - Re: [PATCH] lib/rhashtable: consider param->min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180717223057.7wdtjwbusxfqpvur@linux-r8p5>
Date:   Tue, 17 Jul 2018 15:30:57 -0700
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     akpm@...ux-foundation.org, tgraf@...g.ch,
        linux-kernel@...r.kernel.org, Davidlohr Bueso <dbueso@...e.de>,
        netdev@...r.kernel.org
Subject: Re: [PATCH] lib/rhashtable: consider param->min_size when setting
 initial table size

On Mon, 16 Jul 2018, Herbert Xu wrote:

>On Fri, Jul 13, 2018 at 11:25:16PM -0700, Davidlohr Bueso wrote:
>> rhashtable_init() currently does not take into account the user-passed
>> min_size parameter unless param->nelem_hint is set as well. As such,
>> the default size (number of buckets) will always be HASH_DEFAULT_SIZE
>> even if the smallest allowed size is larger than that. Remediate this
>> by unconditionally calling into rounded_hashtable_size() and handling
>> things accordingly.
>>
>> Signed-off-by: Davidlohr Bueso <dbueso@...e.de>
>
>Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
>
>Normally these patches go through netdev so could you please resend
>it with my ack to netdev@...r.kernel.org?

So I've done the resend, but at least would think that routing the
patch through Andrew would work best as he picked up the rhashtable
changes regarding ipc and this touches the same call.

Thanks,
Davidlohr