netdev - Re: [PATCH] net/nfc: Avoid stalls when nfc_alloc_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180719.025224.724580559198605486.davem@davemloft.net>
Date:   Thu, 19 Jul 2018 02:52:24 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     penguin-kernel@...ove.SAKURA.ne.jp
Cc:     sameo@...ux.intel.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org,
        syzbot+d29d18215e477cfbfbdd@...kaller.appspotmail.com
Subject: Re: [PATCH] net/nfc: Avoid stalls when nfc_alloc_send_skb()
 returned NULL.

From: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Date: Wed, 18 Jul 2018 18:57:27 +0900

> syzbot is reporting stalls at nfc_llcp_send_ui_frame() [1]. This is
> because nfc_llcp_send_ui_frame() is retrying the loop without any delay
> when nonblocking nfc_alloc_send_skb() returned NULL.
> 
> Since there is no need to use MSG_DONTWAIT if we retry until
> sock_alloc_send_pskb() succeeds, let's use blocking call.
> Also, in case an unexpected error occurred, let's break the loop
> if blocking nfc_alloc_send_skb() failed.
> 
> [1] https://syzkaller.appspot.com/bug?id=4a131cc571c3733e0eff6bc673f4e36ae48f19c6
> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Reported-by: syzbot <syzbot+d29d18215e477cfbfbdd@...kaller.appspotmail.com>

Applied and queued up for -stable, thanks.