netdev - Re: [net-next v2 1/5] net/tls: Do not enable zero-copy prematurely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Jul 2018 05:23:25 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     vakul.garg@....com
Cc:     netdev@...r.kernel.org, borisp@...lanox.com, aviadye@...lanox.com,
        davejwatson@...com
Subject: Re: [net-next v2 1/5] net/tls: Do not enable zero-copy prematurely

From: Vakul Garg <vakul.garg@....com>
Date: Mon, 16 Jul 2018 21:27:11 +0530

> Zero-copy mode was left enabled even when zerocopy_from_iter() failed.
> Set the zero-copy mode only when zerocopy_from_iter() succeeds. This
> leads to removal of argument 'zc' of function decrypt_skb_update().
> Function decrypt_skb_update() does not need to check whether
> ctx->decrypted is set since it is never called if ctx->decrypted is
> true.
> 
> Signed-off-by: Vakul Garg <vakul.garg@....com>

This adds a warning:

net/tls/tls_sw.c: In function ‘decrypt_skb_update’:
net/tls/tls_sw.c:662:28: warning: unused variable ‘ctx’ [-Wunused-variable]
  struct tls_sw_context_rx *ctx = tls_sw_ctx_rx(tls_ctx);

Also, you must submit a patch series with a proper cover letter
"[net-next vX 0/N] net/tls: ..." explaining what the patch series
is doing, how it is doing it, and why it doing it that way.

You should also provide appropriate "Fixes: " tags to your
patches.

Thank you.