netdev - Re: [PATCH resend -next] lib/rhashtable: consider param->min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180719.052812.1808217805356135440.davem@davemloft.net>
Date:   Thu, 19 Jul 2018 05:28:12 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     dave@...olabs.net
Cc:     herbert@...dor.apana.org.au, akpm@...ux-foundation.org,
        tgraf@...g.ch, linux-kernel@...r.kernel.org, dbueso@...e.de,
        netdev@...r.kernel.org
Subject: Re: [PATCH resend -next] lib/rhashtable: consider param->min_size
 when setting initial table size

From: Davidlohr Bueso <dave@...olabs.net>
Date: Mon, 16 Jul 2018 13:26:13 -0700

> rhashtable_init() currently does not take into account the user-passed
> min_size parameter unless param->nelem_hint is set as well. As such,
> the default size (number of buckets) will always be HASH_DEFAULT_SIZE
> even if the smallest allowed size is larger than that. Remediate this
> by unconditionally calling into rounded_hashtable_size() and handling
> things accordingly.
> 
> Signed-off-by: Davidlohr Bueso <dbueso@...e.de>
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>
> ---
> Resending per Herbert's request with Cc to netdev.

Applied and queued up for -stable, thanks.