netdev - Re: [PATCH net-next v2] net: Move skb decrypted field, avoid explicity copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180719.054226.1422131488167461561.davem@davemloft.net>
Date:   Thu, 19 Jul 2018 05:42:26 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     sbrivio@...hat.com
Cc:     borisp@...lanox.com, sfr@...b.auug.org.au, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: Move skb decrypted field, avoid
 explicity copy

From: Stefano Brivio <sbrivio@...hat.com>
Date: Tue, 17 Jul 2018 11:52:57 +0200

> Commit 784abe24c903 ("net: Add decrypted field to skb")
> introduced a 'decrypted' field that is explicitly copied on skb
> copy and clone.
> 
> Move it between headers_start[0] and headers_end[0], so that we
> don't need to copy it explicitly as it's copied by the memcpy()
> in __copy_skb_header().
> 
> While at it, drop the assignment in __skb_clone(), it was
> already redundant.
> 
> This doesn't change the size of sk_buff or cacheline boundaries.
> 
> The 15-bits hole before tc_index becomes a 14-bits hole, and
> will be again a 15-bits hole when this change is merged with
> commit 8b7008620b84 ("net: Don't copy pfmemalloc flag in
> __copy_skb_header()").
> 
> v2: as reported by kbuild test robot (oops, I forgot to build
>     with CONFIG_TLS_DEVICE it seems), we can't use
>     CHECK_SKB_FIELD() on a bit-field member. Just drop the
>     check for the moment being, perhaps we could think of some
>     magic to also check bit-field members one day.
> 
> Fixes: 784abe24c903 ("net: Add decrypted field to skb")
> Signed-off-by: Stefano Brivio <sbrivio@...hat.com>

Applied.