netdev - Re: [PATCH] net: usb: asix: replace mii_nway

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180719.054350.891466987638140875.davem@davemloft.net>
Date:   Thu, 19 Jul 2018 05:43:50 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     lynxis@...0.eu
Cc:     linux-usb@...r.kernel.org, robert.foss@...labora.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: usb: asix: replace mii_nway_restart in resume path

From: Alexander Couzens <lynxis@...0.eu>
Date: Tue, 17 Jul 2018 13:17:09 +0200

> mii_nway_restart is not pm aware which results in a rtnl deadlock.
> Implement mii_nway_restart manual by setting BMCR_ANRESTART if
> BMCR_ANENABLE is set.
> 
> To reproduce:
> * plug an asix based usb network interface
> * wait until the device enters PM (~5 sec)
> * `ip link set eth1 up` will never return
> 
> Fixes: d9fe64e51114 ("net: asix: Add in_pm parameter")
> Signed-off-by: Alexander Couzens <lynxis@...0.eu>

Applied and queued up for -stable, thank you.