netdev - Re: [PATCH iproute2 2/5] bpf: move bpf_elf_map fixup notification under verbose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Jul 2018 17:24:52 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     dsahern@...il.com, alexei.starovoitov@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 2/5] bpf: move bpf_elf_map fixup notification
 under verbose

On Wed, 18 Jul 2018 01:31:19 +0200, Daniel Borkmann wrote:
> No need to spam the user with this if it can be fixed gracefully
> anyway. Therefore, move it under verbose option.
> 
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> ---
>  lib/bpf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/bpf.c b/lib/bpf.c
> index 4e26c0d..42093db 100644
> --- a/lib/bpf.c
> +++ b/lib/bpf.c
> @@ -1893,9 +1893,9 @@ static int bpf_fetch_maps_end(struct bpf_elf_ctx *ctx)
>  	}
>  
>  	memcpy(ctx->maps, fixup, sizeof(fixup));
> -
> -	printf("Note: %zu bytes struct bpf_elf_map fixup performed due to size mismatch!\n",
> -	       sizeof(struct bpf_elf_map) - ctx->map_len);
> +	if (ctx->verbose)
> +		printf("%zu bytes struct bpf_elf_map fixup performed due to size mismatch!\n",
> +		       sizeof(struct bpf_elf_map) - ctx->map_len);

Glad to see that :)  FWIW you seem to use fprintf(stderr, ) in the btf
patch for information messages, I think that's a good approach.
Separating "results" from "info/error" messages.  Helps JSON too.
Probably doesn't matter much for this message.