netdev - Re: [PATCH iproute2 5/5] bpf: implement btf handling and map annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180717172743.6e5e1231@cakuba.lan>
Date:   Tue, 17 Jul 2018 17:27:43 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     dsahern@...il.com, alexei.starovoitov@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 5/5] bpf: implement btf handling and map
 annotation

On Wed, 18 Jul 2018 01:31:22 +0200, Daniel Borkmann wrote:
>   # bpftool map dump id 386
>    [{
>         "key": 0,
>         "value": {
>             "": {
>                 "value": 0,
>                 "ifindex": 0,
>                 "mac": []
>             }
>         }
>     },{
>         "key": 1,
>         "value": {
>             "": {
>                 "value": 0,
>                 "ifindex": 0,
>                 "mac": []
>             }
>         }
>     },{
>   [...]

Ugh, the empty keys ("") look worrying, we should probably improve
handling of anonymous structs in bpftool :S

FWIW all the patches look nice to me!  Thanks for keeping the support
for loading programs from the ".text" section :)