netdev - Re: [PATCH iproute2 5/5] bpf: implement btf handling and map annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d63310f1-fca2-eace-db71-5063ebedc971@iogearbox.net>
Date:   Wed, 18 Jul 2018 10:42:32 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     dsahern@...il.com, alexei.starovoitov@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 5/5] bpf: implement btf handling and map
 annotation

On 07/18/2018 02:27 AM, Jakub Kicinski wrote:
> On Wed, 18 Jul 2018 01:31:22 +0200, Daniel Borkmann wrote:
>>   # bpftool map dump id 386
>>    [{
>>         "key": 0,
>>         "value": {
>>             "": {
>>                 "value": 0,
>>                 "ifindex": 0,
>>                 "mac": []
>>             }
>>         }
>>     },{
>>         "key": 1,
>>         "value": {
>>             "": {
>>                 "value": 0,
>>                 "ifindex": 0,
>>                 "mac": []
>>             }
>>         }
>>     },{
>>   [...]
> 
> Ugh, the empty keys ("") look worrying, we should probably improve
> handling of anonymous structs in bpftool :S

Yeah agree, I think it would be nice to see a more pahole style dump
where we have types and member names along with the value as otherwise
it might be a bit confusing.

> FWIW all the patches look nice to me!  Thanks for keeping the support
> for loading programs from the ".text" section :)

The test_offload.py from BPF kselftests helped a lot in that! :)

Thanks,
Daniel