netdev - Re: [PATCH net-next,v2] net: rename ndo_setup_tc to ndo_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0UcTihfkgzO=AZ=J_hS-3gg_wjMYr+kJGAWobQ_Wkdfp9g@mail.gmail.com>
Date:   Thu, 19 Jul 2018 08:18:20 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     Netdev <netdev@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us>,
        Tom Lendacky <thomas.lendacky@....com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ariel Elior <ariel.elior@...ium.com>,
        Michael Chan <michael.chan@...adcom.com>,
        Santosh Raspatur <santosh@...lsio.com>, madalin.bucur@....com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Jiri Pirko <jiri@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>,
        Ganesh Goudar <ganeshgr@...lsio.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        linux-net-drivers@...arflare.com, peppe.cavallaro@...com,
        alexandre.torgue@...com, joabreu@...opsys.com,
        grygorii.strashko@...com, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Subject: Re: [PATCH net-next,v2] net: rename ndo_setup_tc to ndo_setup_offload

On Wed, Jul 18, 2018 at 5:11 PM, Pablo Neira Ayuso <pablo@...filter.org> wrote:
> One of the recurring complaints is that we do not have, as a driver
> writer, a central location from which we would be fed offloading rules
> into a NIC. This was brought up again during Netconf'18 in Boston.
>
> This patch just renames ndo_setup_tc to ndo_setup_offload as a very
> early initial work to prepare for follow up patch that discuss unified
> flow representation for the existing offload programming APIs.
>
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
> Acked-by: Jiri Pirko <jiri@...lanox.com>
> Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

One request I would have here is to not bother updating the individual
driver function names. For now I would say we could leave the
"_setup_tc" in the naming of the driver functions itself and just
update the name of the net device operation. Renaming the driver
functions just adds unnecessary overhead and complexity to the patch
and will make it more difficult to maintain. When we get around to
adding additional functionality that relates to the rename we could
address renaming the function on a per driver basis in the future.