netdev - Re: [PATCH iproute2-next v10] Add support for CAKE qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87r2jz2qxi.fsf@toke.dk>
Date:   Thu, 19 Jul 2018 17:20:09 +0200
From:   Toke Høiland-Jørgensen <toke@...e.dk>
To:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org
Cc:     cake@...ts.bufferbloat.net, Dave Taht <dave.taht@...il.com>
Subject: Re: [PATCH iproute2-next v10] Add support for CAKE qdisc

David Ahern <dsahern@...il.com> writes:

> On 7/19/18 4:53 AM, Toke Høiland-Jørgensen wrote:
>> A few comments below; will fix the rest.
>> 
>>>> +			print_uint(PRINT_JSON, "bandwidth", NULL, bandwidth);
>>>> +			print_string(PRINT_FP, NULL, "bandwidth %s ", sprint_rate(bandwidth, b1));
>>>> +		} else
>>>> +			print_string(PRINT_ANY, "bandwidth", "bandwidth %s ", "unlimited");
>>>> +	}
>>>> +	if (tb[TCA_CAKE_AUTORATE] &&
>>>> +		RTA_PAYLOAD(tb[TCA_CAKE_AUTORATE]) >= sizeof(__u32)) {
>>>> +		autorate = rta_getattr_u32(tb[TCA_CAKE_AUTORATE]);
>>>> +		if(autorate == 1)
>>>> +			print_string(PRINT_ANY, "autorate", "autorate_%s ", "ingress");
>
> This just caught me eye as well ... why the '_' after autorate?

Well, the parameter is called autorate_ingress to make it a single
token. When adding JSON support I picked the key/value representation
mostly because we could theoretically add other autorate modes in the
future (the netlink parameter allows it).

-Toke