netdev - Re: [net-next 1/1] tipc: make link capability update thread safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180720.123641.478242247443729049.davem@davemloft.net>
Date:   Fri, 20 Jul 2018 12:36:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jon.maloy@...csson.com
Cc:     netdev@...r.kernel.org, gordan.mihaljevic@...tech.com.au,
        tung.q.nguyen@...tech.com.au, hoang.h.le@...tech.com.au,
        canh.d.luu@...tech.com.au, ying.xue@...driver.com,
        tipc-discussion@...ts.sourceforge.net
Subject: Re: [net-next 1/1] tipc: make link capability update thread safe

From: Jon Maloy <jon.maloy@...csson.com>
Date: Wed, 18 Jul 2018 19:50:06 +0200

> The commit referred to below introduced an update of the link
> capabilities field that is not safe. Given the recently added
> feature to remove idle node and link items after 5 minutes, there
> is a small risk that the update will happen at the very moment the
> targeted link is being removed. To avoid this we have to perform
> the update inside the node item's write lock protection.
> 
> Fixes: 9012de508956 ("tipc: add sequence number check for link STATE messages")
> Signed-off-by: Jon Maloy <jon.maloy@...csson.com>

Applied, thanks Jon.