netdev - Re: [PATCH net-next] net/tls: Do not call msg_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180725014920.GJ30522@ZenIV.linux.org.uk>
Date:   Wed, 25 Jul 2018 02:49:20 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Vakul Garg <vakul.garg@....com>
Cc:     netdev@...r.kernel.org, borisp@...lanox.com, aviadye@...lanox.com,
        davejwatson@...com, davem@...emloft.net
Subject: Re: [PATCH net-next] net/tls: Do not call msg_data_left() twice

On Tue, Jul 24, 2018 at 04:41:18PM +0530, Vakul Garg wrote:
> In function tls_sw_sendmsg(), msg_data_left() needs to be called only
> once. The second invocation of msg_data_left() for assigning variable
> try_to_copy can be removed and merged with the first one.

You do realize that msg_data_left(msg) is simply msg->msg_iter.count?
So I'm not at all sure that your change will be an overall win...