netdev - Re: [PATCH net-next] net/tls: Do not call msg_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DB7PR04MB4252B41D9CEB9799DCDBCC848B540@DB7PR04MB4252.eurprd04.prod.outlook.com>
Date:   Wed, 25 Jul 2018 01:54:36 +0000
From:   Vakul Garg <vakul.garg@....com>
To:     Al Viro <viro@...iv.linux.org.uk>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "borisp@...lanox.com" <borisp@...lanox.com>,
        "aviadye@...lanox.com" <aviadye@...lanox.com>,
        "davejwatson@...com" <davejwatson@...com>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH net-next] net/tls: Do not call msg_data_left() twice

From: Al Viro
Sent: Wednesday, 25 July, 7:19 AM
Subject: Re: [PATCH net-next] net/tls: Do not call msg_data_left() twice
To: Vakul Garg
Cc: netdev@...r.kernel.org, borisp@...lanox.com, aviadye@...lanox.com, davejwatson@...com, davem@...emloft.net

On Tue, Jul 24, 2018 at 04:41:18PM +0530, Vakul Garg wrote: > In function tls_sw_sendmsg(), msg_data_left() needs to be called only > once. The second invocation of msg_data_left() for assigning variable > try_to_copy can be removed and merged with the first one. You do realize that msg_data_left(msg) is simply msg->msg_iter.count? So I'm not at all sure that your change will be an overall win...

Agreed, msg_data_left is inexpensive. It's just that is pointless to call it again.

Content of type "text/html" skipped