netdev - Re: [net-next 10/13] net/mlx5e: Add support for XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66f0a6c6-eb81-b348-2e1a-1fb8c98f73d7@mellanox.com>
Date:   Mon, 30 Jul 2018 16:09:47 +0300
From:   Tariq Toukan <tariqt@...lanox.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>,
        Saeed Mahameed <saeedm@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Eugenia Emantayev <eugenia@...lanox.com>
Subject: Re: [net-next 10/13] net/mlx5e: Add support for XDP_REDIRECT in
 device-out side



On 30/07/2018 4:06 PM, Jesper Dangaard Brouer wrote:
> 
> On Mon, 30 Jul 2018 14:10:21 +0200 Jesper Dangaard Brouer <brouer@...hat.com> wrote:
> 
>> On Thu, 26 Jul 2018 15:56:44 -0700 Saeed Mahameed <saeedm@...lanox.com> wrote:
>>
>>> +int mlx5e_xdp_xmit(struct net_device *dev, int n, struct xdp_frame **frames,
>>> +		   u32 flags)
>>> +{
> [...]
>>> +		xdpi.dma_addr = dma_map_single(sq->pdev, xdpf->data, xdpf->len,
>>> +					       DMA_TO_DEVICE);
>>> +		if (unlikely(dma_mapping_error(sq->pdev, xdpi.dma_addr))) {
>>> +			drops++;
>>
>> I think you are missing a xdp_return_frame_rx_napi(xdpf) here.
> 
> I see it already got applied... I'll send a fixup later...
> 

Yes it is applied, I can do it myself. Just let me know what you prefer.