netdev - Re: [RFC PATCH net-next v2 09/17] ethtool: implement GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180730132107.GB10626@nanopsycho>
Date:   Mon, 30 Jul 2018 15:21:07 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        David Miller <davem@...emloft.net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Roopa Prabhu <roopa@...ulusnetworks.com>,
        Jakub Kicinski <kubakici@...pl>,
        "John W. Linville" <linville@...driver.com>
Subject: Re: [RFC PATCH net-next v2 09/17] ethtool: implement GET_DRVINFO
 message

Mon, Jul 30, 2018 at 02:53:27PM CEST, mkubecek@...e.cz wrote:

[...]

>+/* GET_DRVINFO / SET_DRVINFO */
>+
>+enum {
>+	ETHA_DRVINFO_UNSPEC,
>+	ETHA_DRVINFO_DEV,			/* nest - ETHA_DEV_* */
>+	ETHA_DRVINFO_DRIVER,			/* string */
>+	ETHA_DRVINFO_VERSION,			/* string */
>+	ETHA_DRVINFO_FWVERSION,			/* string */
>+	ETHA_DRVINFO_BUSINFO,			/* string */
>+	ETHA_DRVINFO_EROM_VER,			/* string */
>+	ETHA_DRVINFO_N_PRIV_FLAGS,		/* u32 */
>+	ETHA_DRVINFO_N_STATS,			/* u32 */
>+	ETHA_DRVINFO_TESTINFO_LEN,		/* u32 */
>+	ETHA_DRVINFO_EEDUMP_LEN,		/* u32 */
>+	ETHA_DRVINFO_REGDUMP_LEN,		/* u32 */

This is a nice example of why 1:1 ioctl->netlink conversion would be
a big mistake.

I understand that for ioclt, getting lengths of various things is
important. Userspace can prepare buffer for next ioctl which would
actually do dump transfer. However in netlink, this is totally pointless
as the dump goes into userspace in multiple netlink messages.

We need to figure out the netlink uapi from scratch.

[...]