netdev - Re: [PATCH net-next 2/4] tcp: add data bytes retransmitted stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180730151414.4ce34375@xeon-e3>
Date:   Mon, 30 Jul 2018 15:14:14 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Wei Wang <weiwan@...gle.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        Yuchung Cheng <ycheng@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 2/4] tcp: add data bytes retransmitted stats

On Mon, 30 Jul 2018 14:59:09 -0700
Wei Wang <weiwan@...gle.com> wrote:

> +	stats = alloc_skb(9 * nla_total_size_64bit(sizeof(u64)) +
>  			  7 * nla_total_size(sizeof(u32)) +
>  			  3 * nla_total_size(sizeof(u8)), GFP_ATOMIC);

This is getting a bit awkward.
Maybe use the style used in other drivers that have a get_size function
like tun_get_size().