netdev - Re: [PATCH net-next 2/4] tcp: add data bytes retransmitted stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEA6p_D3ccdu9u1kUqz45iyc2cdZ7EFbQ=p3cbZa-73L9uU=9Q@mail.gmail.com>
Date:   Mon, 30 Jul 2018 15:51:31 -0700
From:   Wei Wang <weiwan@...gle.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Yuchung Cheng <ycheng@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 2/4] tcp: add data bytes retransmitted stats

On Mon, Jul 30, 2018 at 3:14 PM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> On Mon, 30 Jul 2018 14:59:09 -0700
> Wei Wang <weiwan@...gle.com> wrote:
>
> > +     stats = alloc_skb(9 * nla_total_size_64bit(sizeof(u64)) +
> >                         7 * nla_total_size(sizeof(u32)) +
> >                         3 * nla_total_size(sizeof(u8)), GFP_ATOMIC);
>
> This is getting a bit awkward.
> Maybe use the style used in other drivers that have a get_size function
> like tun_get_size().

Thanks Stephen. OK. Will add a patch at the beginning to do this refactor.