netdev - Re: [net-next PATCH] mlx5: handle DMA mapping error case for XDP redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180731.094700.2256113713700645687.davem@davemloft.net>
Date:   Tue, 31 Jul 2018 09:47:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tariqt@...lanox.com
Cc:     brouer@...hat.com, saeedm@...lanox.com, netdev@...r.kernel.org,
        eugenia@...lanox.com
Subject: Re: [net-next PATCH] mlx5: handle DMA mapping error case for XDP
 redirect

From: Tariq Toukan <tariqt@...lanox.com>
Date: Tue, 31 Jul 2018 09:35:37 +0300

> On 30/07/2018 8:49 PM, Jesper Dangaard Brouer wrote:
>> Commit 58b99ee3e3eb ("net/mlx5e: Add support for XDP_REDIRECT in
>> device-out side")
>> forgot to return/free the xdp_frame in case the DMA mapping failed,
>> correct this.
>> Also DMA unmap the frame in case mlx5e_xmit_xdp_frame() fails.
>> Fixes: 58b99ee3e3eb ("net/mlx5e: Add support for XDP_REDIRECT in
>> device-out side")
>> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
 ...
> Reviewed-by: Tariq Toukan <tariqt@...lanox.com>

Applied.