netdev - Re: [PATCH net-next] rxrpc: remove redundant variables 'xcall','sp' and 'did

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22b396e6-1e8d-cfc1-8dfd-955ca23f7db8@huawei.com>
Date:   Wed, 1 Aug 2018 17:19:12 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     David Howells <dhowells@...hat.com>
CC:     <davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <linux-afs@...ts.infradead.org>
Subject: Re: [PATCH net-next] rxrpc: remove redundant variables 'xcall','sp'
 and 'did_discard'


On 2018/8/1 16:28, David Howells wrote:
> YueHaibing <yuehaibing@...wei.com> wrote:
> 
>>  		while (*pp) {
>>  			parent = *pp;
>> -			xcall = rb_entry(parent, struct rxrpc_call, sock_node);
>>  			if (user_call_ID < call->user_call_ID)
>>  				pp = &(*pp)->rb_left;
>>  			else if (user_call_ID > call->user_call_ID)
> 
> No, this is an actual bug.  The if-conditions should be using xcall-> not
> call->.

yes, I will post a new patch, thanks.

> 
>> -		sp = rxrpc_skb(skb);
> 
> Yeah, that's fine.
> 
>> -	did_discard = true;
> 
> Hmmm...  It looks like I intended something with this, but I don't remember
> what now.  I think it can be removed.
> 
> David
> 
> .
>