netdev - Re: [patch net-next 2/2] net: sched: fix notifications for action-held chains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 1 Aug 2018 11:24:31 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        mlxsw@...lanox.com
Subject: Re: [patch net-next 2/2] net: sched: fix notifications for
 action-held chains

Wed, Aug 01, 2018 at 06:27:28AM CEST, xiyou.wangcong@...il.com wrote:
>On Tue, Jul 31, 2018 at 5:10 AM Jiri Pirko <jiri@...nulli.us> wrote:
>>
>> From: Jiri Pirko <jiri@...lanox.com>
>>
>> Chains that only have action references serve as placeholders.
>> Until a non-action reference is created, user should not be aware
>> of the chain. Also he should not receive any notifications about it.
>> So send notifications for the new chain only in case the chain gets
>> the first non-action reference. Symmetrically to that, when
>> the last non-action reference is dropped, send the notification about
>> deleted chain.
>>
>> Reported-by: Cong Wang <xiyou.wangcong@...il.com>
>> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
>
>I think __tcf_chain_{get,put}() can be static.

In fact, tcf_chain_get/put could be now static too. Will send v2.
Thanks!

>
>Other than that,
>
>Acked-by: Cong Wang <xiyou.wangcong@...il.com>
>
>Thanks.