netdev - Re: [PATCH net-next v2] cpumask: make cpumask_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180813.085849.2269837466744759310.davem@davemloft.net>
Date:   Mon, 13 Aug 2018 08:58:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     willemdebruijn.kernel@...il.com
Cc:     netdev@...r.kernel.org, caleb.raitto@...il.com, lkp@...el.com,
        willemb@...gle.com
Subject: Re: [PATCH net-next v2] cpumask: make cpumask_next_wrap available
 without smp

From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Date: Sun, 12 Aug 2018 09:14:03 -0400

> From: Willem de Bruijn <willemb@...gle.com>
> 
> The kbuild robot shows build failure on machines without CONFIG_SMP:
> 
>   drivers/net/virtio_net.c:1916:10: error:
>     implicit declaration of function 'cpumask_next_wrap'
> 
> cpumask_next_wrap is exported from lib/cpumask.o, which has
> 
>     lib-$(CONFIG_SMP) += cpumask.o
> 
> same as other functions, also define it as static inline in the
> NR_CPUS==1 branch in include/linux/cpumask.h.
> 
> If wrap is true and next == start, return nr_cpumask_bits, or 1.
> Else wrap across the range of valid cpus, here [0].
> 
> Fixes: 2ca653d607ce ("virtio_net: Stripe queue affinities across cores.")
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied, thanks Willem.