netdev - Re: [net-next,v2] cpumask: make cpumask_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Aug 2018 18:01:44 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        caleb.raitto@...il.com, lkp@...el.com,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [net-next,v2] cpumask: make cpumask_next_wrap available without
 smp

On Sun, Aug 12, 2018 at 09:14:03AM -0400, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> The kbuild robot shows build failure on machines without CONFIG_SMP:

If this was reported by kbuild robot, then could you credit him with
Reported-by?

> 
>   drivers/net/virtio_net.c:1916:10: error:
>     implicit declaration of function 'cpumask_next_wrap'
> 
> cpumask_next_wrap is exported from lib/cpumask.o, which has
> 
>     lib-$(CONFIG_SMP) += cpumask.o
> 
> same as other functions, also define it as static inline in the
> NR_CPUS==1 branch in include/linux/cpumask.h.
> 
> If wrap is true and next == start, return nr_cpumask_bits, or 1.
> Else wrap across the range of valid cpus, here [0].
> 
> Fixes: 2ca653d607ce ("virtio_net: Stripe queue affinities across cores.")
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
> ---
>  include/linux/cpumask.h | 7 +++++++
>  1 file changed, 7 insertions(+)
>

Tested-by: Krzysztof Kozlowski <krzk@...nel.org>

This fixes second build break of virtio driver in recent few days... I
wonder what happened with build-testing of own commits... or at least
reading kbuild robot mails.

Best regards,
Krzysztof