lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Aug 2018 08:46:41 -0600 From: David Ahern <dsahern@...il.com> To: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>, "David S. Miller" <davem@...emloft.net> Cc: netdev@...r.kernel.org, dsahern@...nel.org Subject: Re: [PATCH v3 net-next] veth: Free queues on link delete On 8/15/18 2:07 AM, Toshiaki Makita wrote: > David Ahern reported memory leak in veth. > ... > veth_rq allocated in veth_newlink() was not freed on dellink. > > We need to free up them after veth_close() so that any packets will not > reference the queues afterwards. Thus free them in veth_dev_free() in > the same way as freeing stats structure (vstats). > > Also move queues allocation to veth_dev_init() to be in line with stats > allocation. > > Fixes: 638264dc90227 ("veth: Support per queue XDP ring") > Reported-by: David Ahern <dsahern@...il.com> > Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp> > --- > This is a fix for a bug which exists only in net-next. > Let me know if I should wait for -next merging into net or reopen of -next. > > drivers/net/veth.c | 70 +++++++++++++++++++++++++----------------------------- > 1 file changed, 33 insertions(+), 37 deletions(-) > Reviewed-by: David Ahern <dsahern@...il.com> Tested-by: David Ahern <dsahern@...il.com>
Powered by blists - more mailing lists