netdev - Re: [PATCH v3 net-next] veth: Free queues on link delete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180816.122256.7265384004790675.davem@davemloft.net>
Date:   Thu, 16 Aug 2018 12:22:56 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     makita.toshiaki@....ntt.co.jp
Cc:     netdev@...r.kernel.org, dsahern@...il.com, dsahern@...nel.org
Subject: Re: [PATCH v3 net-next] veth: Free queues on link delete

From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Date: Wed, 15 Aug 2018 17:07:29 +0900

> David Ahern reported memory leak in veth.
 ...
> veth_rq allocated in veth_newlink() was not freed on dellink.
> 
> We need to free up them after veth_close() so that any packets will not
> reference the queues afterwards. Thus free them in veth_dev_free() in
> the same way as freeing stats structure (vstats).
> 
> Also move queues allocation to veth_dev_init() to be in line with stats
> allocation.
> 
> Fixes: 638264dc90227 ("veth: Support per queue XDP ring")
> Reported-by: David Ahern <dsahern@...il.com>
> Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>

Applied, thank you.