netdev - Re: Checkpatch False positive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Aug 2018 13:22:50 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
        netdev <netdev@...r.kernel.org>,
        Linux Docs <linux-doc@...r.kernel.org>
Subject: Re: Checkpatch False positive

On Mon, Aug 20, 2018 at 01:21:30PM -0700, Jeff Kirsher wrote:
> Checkpatch.pl should probably exclude *.rst files from the SPDX License
> Identifier check, since they are documentational files, like *.txt. 

They're still copyrighted work, so they should still have SPDX tags
to identify their license.

checkpatch has:

                                } elsif ($realfile =~ /\.rst$/) {
                                        $comment = '..';

so we're explicitly including rst files in the checking for now.