netdev - Re: Checkpatch False positive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <933f909db5ae9bc96c5be2bb503081eb5714adbc.camel@intel.com>
Date:   Mon, 20 Aug 2018 13:32:33 -0700
From:   Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>,
        netdev <netdev@...r.kernel.org>,
        Linux Docs <linux-doc@...r.kernel.org>
Subject: Re: Checkpatch False positive

On Mon, 2018-08-20 at 13:22 -0700, Matthew Wilcox wrote:
> On Mon, Aug 20, 2018 at 01:21:30PM -0700, Jeff Kirsher wrote:
> > Checkpatch.pl should probably exclude *.rst files from the SPDX
> > License
> > Identifier check, since they are documentational files, like
> > *.txt. 
> 
> They're still copyrighted work, so they should still have SPDX tags
> to identify their license.
> 
> checkpatch has:
> 
>                                 } elsif ($realfile =~ /\.rst$/) {
>                                         $comment = '..';
> 
> so we're explicitly including rst files in the checking for now.

Ah, sorry.  I did not catch that they started to include SPDX-License-
Identifiers for RST files, thanks Matthew.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)