netdev - Re: [PATCH iproute2] iproute: make clang happy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180820155223.0569b849@xeon-e3>
Date:   Mon, 20 Aug 2018 15:52:23 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Mahesh Bandewar <mahesh@...dewar.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Mahesh Bandewar <maheshb@...gle.com>
Subject: Re: [PATCH iproute2] iproute: make clang happy

On Mon, 20 Aug 2018 14:42:15 -0700
Mahesh Bandewar <mahesh@...dewar.net> wrote:

> diff --git a/tc/m_ematch.c b/tc/m_ematch.c
> index ace4b3dd738b..a524b520b276 100644
> --- a/tc/m_ematch.c
> +++ b/tc/m_ematch.c
> @@ -277,6 +277,7 @@ static int flatten_tree(struct ematch *head, struct ematch *tree)
>  	return count;
>  }
>  
> +__attribute__((format(printf, 5, 6)))
>  int em_parse_error(int err, struct bstr *args, struct bstr *carg,
>  		   struct ematch_util *e, char *fmt, ...)

I think the printf attribute needs to go on the function prototype
here:
tc/m_ematch.h:extern int em_parse_error(int err, struct bstr *args, struct bstr *carg,


PS: I need to take the extern of  those function prototypes.