lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Aug 2018 16:38:17 -0700 From: Mahesh Bandewar (महेश बंडेवार) <maheshb@...gle.com> To: Stephen Hemminger <stephen@...workplumber.org> Cc: Mahesh Bandewar <mahesh@...dewar.net>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH iproute2] iproute: make clang happy On Mon, Aug 20, 2018 at 3:52 PM, Stephen Hemminger <stephen@...workplumber.org> wrote: > On Mon, 20 Aug 2018 14:42:15 -0700 > Mahesh Bandewar <mahesh@...dewar.net> wrote: > >> diff --git a/tc/m_ematch.c b/tc/m_ematch.c >> index ace4b3dd738b..a524b520b276 100644 >> --- a/tc/m_ematch.c >> +++ b/tc/m_ematch.c >> @@ -277,6 +277,7 @@ static int flatten_tree(struct ematch *head, struct ematch *tree) >> return count; >> } >> >> +__attribute__((format(printf, 5, 6))) >> int em_parse_error(int err, struct bstr *args, struct bstr *carg, >> struct ematch_util *e, char *fmt, ...) > > I think the printf attribute needs to go on the function prototype > here: > tc/m_ematch.h:extern int em_parse_error(int err, struct bstr *args, struct bstr *carg, > The attributes are attached to the definitions only and not prototype declarations. Please see the definition/declaration for jsonw_printf() in the same patch. > > PS: I need to take the extern of those function prototypes.
Powered by blists - more mailing lists