netdev - Re: [PATCH 1/1] net/rds: Use rdma_read_gids to get connection SGID/DGID in IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d16d1840-e1d9-716b-715a-9dce1e8630e3@oracle.com>
Date:   Sat, 25 Aug 2018 12:24:17 -0700
From:   "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
To:     Zhu Yanjun <yanjun.zhu@...cle.com>, davem@...emloft.net,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        rds-devel@....oracle.com
Subject: Re: [PATCH 1/1] net/rds: Use rdma_read_gids to get connection
 SGID/DGID in IPv6

On 8/25/18 12:19 AM, Zhu Yanjun wrote:
> In IPv4, the newly introduced rdma_read_gids is used to read the SGID/DGID
> for the connection which returns GID correctly for RoCE transport as well.
> 
> In IPv6, rdma_read_gids is also used. The following are why rdma_read_gids
> is introduced.
> 
> rdma_addr_get_dgid() for RoCE for client side connections returns MAC
> address, instead of DGID.
> rdma_addr_get_sgid() for RoCE doesn't return correct SGID for IPv6 and
> when more than one IP address is assigned to the netdevice.
> 
> So the transport agnostic rdma_read_gids() API is provided by rdma_cm
> module.
> 
> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>
> ---
Looks ok.
Acked-by: Santosh Shilimkar <santosh.shilimkar@...cle.com>