netdev - Re: [PATCH net] mlxsw: spectrum_switchdev: Do not leak RIFs when removing bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180825.162923.188681079226490582.davem@davemloft.net>
Date:   Sat, 25 Aug 2018 16:29:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, petrm@...lanox.com,
        alexpe@...lanox.com, mlxsw@...lanox.com
Subject: Re: [PATCH net] mlxsw: spectrum_switchdev: Do not leak RIFs when
 removing bridge

From: Ido Schimmel <idosch@...lanox.com>
Date: Fri, 24 Aug 2018 15:41:35 +0300

> When a bridge device is removed, the VLANs are flushed from each
> configured port. This causes the ports to decrement the reference count
> on the associated FIDs (filtering identifier). If the reference count of
> a FID is 1 and it has a RIF (router interface), then this RIF is
> destroyed.
> 
> However, if no port is member in the VLAN for which a RIF exists, then
> the RIF will continue to exist after the removal of the bridge. To
> reproduce:
> 
> # ip link add name br0 type bridge vlan_filtering 1
> # ip link set dev swp1 master br0
> # ip link add link br0 name br0.10 type vlan id 10
> # ip address add 192.0.2.0/24 dev br0.10
> # ip link del dev br0
> 
> The RIF associated with br0.10 continues to exist.
> 
> Fix this by iterating over all the bridge device uppers when it is
> destroyed and take care of destroying their RIFs.
> 
> Fixes: 99f44bb3527b ("mlxsw: spectrum: Enable L3 interfaces on top of bridge devices")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reviewed-by: Petr Machata <petrm@...lanox.com>

Applied and queued up for -stable, thanks.