netdev - Re: [PATCH v3 net 1/1] net: macb: Fix regression breaking non-MDIO fixed-link PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180825.173102.333761398996346302.davem@davemloft.net>
Date:   Sat, 25 Aug 2018 17:31:02 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     a.fatoum@...gutronix.de
Cc:     andrew@...n.ch, nicolas.ferre@...rochip.com, kernel@...gutronix.de,
        netdev@...r.kernel.org, mdf@...nel.org, brad.mouring@...com,
        f.fainelli@...il.com
Subject: Re: [PATCH v3 net 1/1] net: macb: Fix regression breaking non-MDIO
 fixed-link PHYs

From: Ahmad Fatoum <a.fatoum@...gutronix.de>
Date: Tue, 21 Aug 2018 17:35:48 +0200

> commit 739de9a1563a ("net: macb: Reorganize macb_mii bringup") broke
> initializing macb on the EVB-KSZ9477 eval board.
> There, of_mdiobus_register was called even for the fixed-link representing
> the RGMII-link to the switch with the result that the driver attempts to
> enumerate PHYs on a non-existent MDIO bus:
> 
> 	libphy: MACB_mii_bus: probed
> 	mdio_bus f0028000.ethernet-ffffffff: fixed-link has invalid PHY address
> 	mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 0
>         [snip]
> 	mdio_bus f0028000.ethernet-ffffffff: scan phy fixed-link at address 31
> 
> The "MDIO" bus registration succeeds regardless, having claimed the reset GPIO,
> and calling of_phy_register_fixed_link later on fails because it tries
> to claim the same GPIO:
> 
> 	macb f0028000.ethernet: broken fixed-link specification
> 
> Fix this by registering the fixed-link before calling mdiobus_register.
> 
> Fixes: 739de9a1563a ("net: macb: Reorganize macb_mii bringup")
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

Applied and queued up for -stable, thanks.