netdev - Re: [PATCH net-next] net/sched: fix type of htb statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 02 Sep 2018 13:57:47 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     florent.fourcot@...irst.fr
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net/sched: fix type of htb statistics

From: Florent Fourcot <florent.fourcot@...irst.fr>
Date: Thu, 30 Aug 2018 16:39:23 +0200

> tokens and ctokens are defined as s64 in htb_class structure,
> and clamped to 32bits value during netlink dumps:
> 
> cl->xstats.tokens = clamp_t(s64, PSCHED_NS2TICKS(cl->tokens),
>                             INT_MIN, INT_MAX);
> 
> Defining it as u32 is working since userspace (tc) is printing it as
> signed int, but a correct definition from the beginning is probably
> better.
> 
> In the same time, 'giants' structure member is unused since years, so
> update the comment to mark it unused.
> 
> Signed-off-by: Florent Fourcot <florent.fourcot@...irst.fr>

Looks good, applied.