netdev - Re: [PATCH 2/2] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180902.135251.1636829495138774363.davem@davemloft.net>
Date:   Sun, 02 Sep 2018 13:52:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     tony@...mide.com
Cc:     netdev@...r.kernel.org, linux-omap@...r.kernel.org,
        devicetree@...r.kernel.org, andrew@...n.ch,
        grygorii.strashko@...com, ivan.khoronzhuk@...aro.org,
        mark.rutland@....com, m-karicheri2@...com, robh+dt@...nel.org
Subject: Re: [PATCH 2/2] net: ethernet: cpsw-phy-sel: prefer phandle for
 phy sel

From: Tony Lindgren <tony@...mide.com>
Date: Wed, 29 Aug 2018 08:00:24 -0700

> The cpsw-phy-sel device is not a child of the cpsw interconnect target
> module. It lives in the system control module.
> 
> Let's fix this issue by trying to use cpsw-phy-sel phandle first if it
> exists and if not fall back to current usage of trying to find the
> cpsw-phy-sel child. That way the phy sel driver can be a child of the
> system control module where it belongs in the device tree.
> 
> Without this fix, we cannot have a proper interconnect target module
> hierarchy in device tree for things like genpd.
> 
> Note that deferred probe is mostly not supported by cpsw and this patch
> does not attempt to fix that. In case deferred probe support is needed,
> this could be added to cpsw_slave_open() and phy_connect() so they start
> handling and returning errors.
> 
> For documenting it, looks like the cpsw-phy-sel is used for all cpsw device
> tree nodes. It's missing the related binding documentation, so let's also
> update the binding documentation accordingly.
> 
> Signed-off-by: Tony Lindgren <tony@...mide.com>

Applied.