[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180905164727.3108bce6@shemminger-XPS-13-9360>
Date: Wed, 5 Sep 2018 16:47:27 +0100
From: Stephen Hemminger <stephen@...workplumber.org>
To: Arseny Maslennikov <ar@...msu.ru>
Cc: linux-rdma@...r.kernel.org, Doug Ledford <dledford@...hat.com>,
Jason Gunthorpe <jgg@...pe.ca>, netdev@...r.kernel.org
Subject: Re: [PATCH v3 3/3] IB/ipoib: Log sysfs 'dev_id' accesses from
userspace
On Mon, 3 Sep 2018 19:13:16 +0300
Arseny Maslennikov <ar@...msu.ru> wrote:
> + if (ndev->dev_id == ndev->dev_port) {
> + netdev_info_once(ndev,
> + "\"%s\" wants to know my dev_id. "
> + "Should it look at dev_port instead?\n",
> + current->comm);
> + netdev_info_once(ndev,
> + "See Documentation/ABI/testing/sysfs-class-net for more info.\n");
> + }
Single line message is sufficient.
Also don't break strings in messages.
> + }
> +
> + ret = sprintf(buf, "%#x\n", ndev->dev_id);
> +
> + return ret;
Why not?
return sprintf...
Powered by blists - more mailing lists